Permissions: More granular access and Project Access page #877

martastain · 2024-10-16T08:09:39Z

Conditional access to project settings tabs based on user permissions

ynput/ayon-backend#389 implements user/permission endpoints that return granular project permissions. Frontend should reflect these permissions and use this object instead of relying on isManager flags.

https://experimental.ayon.dev/docs#tag/Users/operation/get_current_user_permissions
https://experimental.ayon.dev/docs#tag/Users/operation/get_current_user_project_permissions

When the user is a manager, this object is returned accordingly (with all restrictions disabled)

This should (for now) be implemented only in the project settings page

Add Users page to Project settings

Add a new sub-page to project settings that would allow non-managers (but users with project.users write access) to add and remove users to the project (by assigning access groups to them).

Original users page stays the same until we decide what to do with it.
Users pages on project settings is called Users Projects
Use single project selection on the left hand side to filter users by the project.
Project selection also affects project access column to show for that project.
Checkbox button in the toolbar that toggles to filtering by project. This is needed in order to see users with no project access, so they can be added to a project. The switch is called Filter by project access and is default off.
Columns are username, full name, project access.
We should only see users that are active=true.
Right hand side should show selected user header with access summary for project and access groups table (full height).
Feel free to rewrite all of this inspired by user settings.
Use new SearchFilter bar for filtering of users.
SearchFilter bar could filter by project which could remove need for 3. and 5.

Read only users

Access Groups table will need a read only mode.

This requires using a new set of endpoints, more information will be provided.

…ontext flag

… on access rules

…permissions

…d access groups

…uttons logic

…also

… changes

Innders

Random gap here
Admins/managers can't see Anatomy, Project Settings or Project Access

Innders

Site settings blocked
I can land on anatomy tab even if I do not have access to it. I should be redirected to a page I have access to.
Changing project management permissions seems to make no difference.

…en selections exist, renamed components for consistency

…ojects list component when user lacks create project permissions

flynput · 2024-11-11T08:06:02Z

@Innders pushed the latest changes, I realized there is one issue remaining: getting the list of users involved in the selected projects only considers the first project in the selection, that's because we cannot fetch user access groups for multiple projects at once. I would gladly use another endpoint that provides said information @martastain

Innders · 2024-11-11T08:55:18Z

we cannot fetch user access groups for multiple projects at once

The API may not allow it but we can definitely do it by looping over a single endpoint for different projects. Take a look a custom query -> https://redux-toolkit.js.org/rtk-query/usage/customizing-queries#customizing-queries-with-queryfn

There are many examples in the codebase of this.

ayon-frontend/src/services/userDashboard/getUserDashboard.ts

Lines 240 to 269 in cface9e

    
           getProjectsInfo: build.query<GetProjectsInfoResponse, GetProjectsInfoParams>({ 
        
             async queryFn({ projects = [] }, { dispatch, forced }) { 
        
               try { 
        
                 // get project info for each project 
        
                 const projectInfo: $Any = {} 
        
                 for (const project of projects) { 
        
                   // hopefully this will be cached 
        
                   // it also allows for different combination of projects but still use the cache 
        
                   const response = await dispatch( 
        
                     getProjectApi.endpoints.getProjectAnatomy.initiate( 
        
                       { projectName: project }, 
        
                       { forceRefetch: forced }, 
        
                     ), 
        
                   ) 
        
                   if (response.status === 'rejected') { 
        
                     throw 'No projects found' 
        
                   } 
        
                   projectInfo[project] = response.data 
        
                 } 
        
                 return { data: projectInfo, meta: undefined, error: undefined } 
        
               } catch (error: $Any) { 
        
                 console.error(error) 
        
                 return { error, meta: undefined, data: undefined } 
        
               } 
        
             }, 
        
             providesTags: (_res, _error, { projects }) => 
        
               projects.map((projectName) => ({ type: 'project', id: projectName })), 
        
           }),

…stom hook

Innders

User management access

For projects where there is no access, show greyed out in the table and sorted to the bottom.
Tabs are jumping around, they should be calculated based on permissions and stay consistent. Project selection should make no difference.

Project Access

Filtering

Project filtering doesn’t work
Text search doesn’t work
User options should not show admins, managers or services.
User filtering doesn’t filter users in access group tables.
If there is only once access group (from filtering or otherwise) adding should skip dialog and add them straight to that group.
Filtering access groups should also filter options in adding modal
Select/deselect all access groups

…ct permissions on project tab menu display

…s also, added select/deselect all button to access groups modal

…mall refactoring

flynput · 2024-11-13T10:21:23Z

The following items were implemented, the ones missing are either in progress or need more feedback/discussion:

Tabs are jumping around, they should be calculated based on permissions and stay consistent. Project selection should make no difference.
Page padding
Page title Project access
Missing table titles
Only show active projects
User rows too high
Profile image 20px
Top right buttons, correct labels and remove shortcut
Context menu (no dynamic secondary context menu FTM)
Access groups width the same as middle table and weird padding on right
Toast not very descriptive “Operation successful”
Can’t scroll access groups
Empty place holder shouldn’t be table item.

User options should not show admins, managers or services.
User filtering doesn’t filter users in access group tables.
If there is only once access group (from filtering or otherwise) adding should skip dialog and add them straight to that group.
Filtering access groups should also filter options in adding modal
Select/deselect all access groups

…sions

…oject & active filters

…hortcut while in project user acess groups page

flynput · 2024-11-14T09:40:08Z

Added new features to the list:
Add shortcut to button (Shortcut Component)
Block double tapping “A” (or think of shortcuts that don’t conflict)
Shortcut needs to work when just hovering at the moment it only works once selected.

Pending issues:

Resize access groups vertically - not sure how to do it
dynamic context menus

Innders

Project Settings

Add new project button is appearing when it shouldn’t. Home page and users settings page.
Add new project button showing when user does not have permissions.
If user does not have access at all to a project they should not see it in the list. (server issue)
Greyed out project row not working for project settings.
Greyed out project not visible for project access. (only works on anatomy)
Weird loading glitch

Project access

Border radius on panels
Gap at the top too big.
Gap too big between filter and titles
Users don’t see users (are you using graphql?)
Profile image is too big 26px not 20px.
User rows too high, they should be 32px as per figma.
Hover missing on edges for add button.
Rename no access column header Username -> User

Adding/Removing

When multiple selected, pressing A should add all.
Add more should use shortcut A
Add more dialog should show current groups selected
Add more not working?
Remove access button enabled when no user selected or non access user selected.
Context menu, ignore dynamic menu for now. Remove all access menu icon=remove_moderator.
Context menu, match figma text and icons.

Dialog

Select all no background, deselect uses prim container BG. No icon.
Item height should be 32px not 28px.
Keyboard controls: press enter to select/unselect.
Keyboard controls: Cmd/Ctrl + Enter to submit.
Keyboard controls: Cmd/Ctrl + A select all (bonus if easy)
Dialog max height 600px

Filtering

Project options show inactive projects.
Project text search not working.
User options should not show admins, managers or services.
Access Group, has value and has no value (bonus).
Prevent adding search options more than once.
Filters aren’t saving to user frontend preferences.

…github.com:ynput/ayon-frontend into 872-ay-5074-top-level-permissions-for-normal-users

… user lists

martastain linked an issue Oct 16, 2024 that may be closed by this pull request

AY-5074 Top level permissions for normal users #872

Open

martastain added type: feature Adding something new and exciting to the product sponsored This is directly sponsored by a client or community member labels Oct 16, 2024

martastain assigned martastain and flynput Oct 17, 2024

martastain marked this pull request as draft October 17, 2024 14:26

martastain and others added 7 commits October 21, 2024 16:55

fix: show project level access groups

5b9dfb8

generating user permissions endpoints

facace6

feat: project permissions p.o.c.

0b0a55b

feat(settings): add permissions widget

bfffcf7

feat(settings): allow hide disabled groups using hideDisabledGroups c…

229fa04

…ontext flag

chore: hide disabled groups in accessgroup editor

8fb808a

feat: limit project management pages p.o.c.

ed4b0ca

flynput force-pushed the 872-ay-5074-top-level-permissions-for-normal-users branch from c9d93ef to ed4b0ca Compare October 22, 2024 07:17

flynput requested a review from Innders October 22, 2024 07:18

flynput added 4 commits October 22, 2024 11:08

feature(Users): Limiting user access to project settings module based…

ee5c4c8

… on access rules

feature(Users): Adding better placeholder messages when lacking view …

00f661e

…permissions

wip

dac1a86

wip

251a48f

flynput force-pushed the 872-ay-5074-top-level-permissions-for-normal-users branch from e6801a9 to 251a48f Compare October 29, 2024 09:17

flynput added 3 commits November 5, 2024 08:29

feature(Users): Updated Project users access groups page

035312a

wip - mutations added

03252b1

feature(Users): Fetching & filtering users based on project & assigne…

925804f

…d access groups

mkolar unassigned martastain Nov 6, 2024

flynput added 5 commits November 7, 2024 06:46

feature(Users): UI redesign, implemented user panels hover & select b…

3d88c42

…uttons logic

feature(Users): Extracting logic to hook, added remove handler

1e2bc57

feature(Users): Using add handler for users already asssigned groups …

dbe12e6

…also

feature(Users): Updated add/remove logic UI & payload logic, minor UI…

967ecd4

… changes

feature(Users): Re-enabled multiple users remove action

8cf585a

Innders changed the title ~~Use user permissions to limit access to pages~~ Permissions: More granular access and Project Access page Nov 8, 2024

Innders requested changes Nov 8, 2024

View reviewed changes

Innders self-requested a review November 8, 2024 09:41

Innders requested changes Nov 8, 2024

View reviewed changes

flynput added 3 commits November 8, 2024 18:05

feature(Users): Added filtering for projects & users

1b47bbd

feature(Users): Filtering access groups also, respecting filtering wh…

db46674

…en selections exist, renamed components for consistency

feature(Users): User Permissions class refactoring, removed gap in pr…

cface9e

…ojects list component when user lacks create project permissions

feature(Users): Fetching user access data for multiple projects in cu…

bfef113

…stom hook

Innders self-requested a review November 11, 2024 10:35

Innders requested changes Nov 11, 2024

View reviewed changes

flynput added 6 commits November 11, 2024 13:00

feature(Users): Fixing invalidation/cache update issues

28b545d

feature(Users): Refactoring permissions module, considering all proje…

768c349

…ct permissions on project tab menu display

feature(Users): UI/UX tweaks and fixes

735515e

feature(Users): Enabled fuzzy filtering for projects and access group…

a73b3b0

…s also, added select/deselect all button to access groups modal

feature(Users): Added context menu for unassigned users pane, other s…

3ce5014

…mall refactoring

feature(Users): Added context menu for already assigned users

76e44cb

flynput added 3 commits November 13, 2024 15:34

feature(Users): Sorting, marking as inactive projects based on permis…

6c694be

…sions

feature(Users): Filtering add/remove actions depending on selected pr…

466a6e1

…oject & active filters

feature(Users): Adding hover key shortcuts, removing global anatomy s…

29e9f83

…hortcut while in project user acess groups page

Innders marked this pull request as ready for review November 14, 2024 09:52

Innders self-requested a review November 14, 2024 12:41

Innders requested changes Nov 14, 2024

View reviewed changes

Innders and others added 4 commits November 14, 2024 12:45

fix: project access overflow issues

5324060

Merge branch '872-ay-5074-top-level-permissions-for-normal-users' of …

08d5227

…github.com:ynput/ayon-frontend into 872-ay-5074-top-level-permissions-for-normal-users

fix(Editor): Persisting filters, UI/UX tweaks, various fixes

6dd3ca8

fix(Editor): Consistent search filtering between filter component and…

fd5898c

… user lists

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permissions: More granular access and Project Access page #877

Permissions: More granular access and Project Access page #877

martastain commented Oct 16, 2024 •

edited by Innders

Loading

Innders left a comment •

edited

Loading

Innders left a comment •

edited

Loading

flynput commented Nov 11, 2024

Innders commented Nov 11, 2024

Innders left a comment •

edited

Loading

flynput commented Nov 13, 2024

flynput commented Nov 14, 2024

Innders left a comment •

edited by tatiana-ynput

Loading

Permissions: More granular access and Project Access page #877

Are you sure you want to change the base?

Permissions: More granular access and Project Access page #877

Conversation

martastain commented Oct 16, 2024 • edited by Innders Loading

Conditional access to project settings tabs based on user permissions

Add Users page to Project settings

Read only users

Innders left a comment • edited Loading

Choose a reason for hiding this comment

Innders left a comment • edited Loading

Choose a reason for hiding this comment

flynput commented Nov 11, 2024

Innders commented Nov 11, 2024

Innders left a comment • edited Loading

Choose a reason for hiding this comment

flynput commented Nov 13, 2024

flynput commented Nov 14, 2024

Innders left a comment • edited by tatiana-ynput Loading

Choose a reason for hiding this comment

martastain commented Oct 16, 2024 •

edited by Innders

Loading

Innders left a comment •

edited

Loading

Innders left a comment •

edited

Loading

Innders left a comment •

edited

Loading

Innders left a comment •

edited by tatiana-ynput

Loading